Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate setup.cfg logic to pyproject.toml #4541

Merged
merged 1 commit into from
May 27, 2024

Conversation

Repiteo
Copy link
Contributor

@Repiteo Repiteo commented May 26, 2024

Converted the setup.cfg settings to a format that pyproject.toml can utilize. Consequently, setup.cfg was removed, as everything is now handled in the pyproject.toml; "source" arrays have had their values swapped as necessary. The only discrepancies in the migration are:

  • metadata.group was removed. This simply isn't a valid option in pyproject.toml, and this info can be extrapolated from project.classifiers.
  • options.data_files was removed. This is considered a discouraged & largely unsupported option, with the listed files already getting caught by tool.setuptools.package-data anyway.

The only other change made is fixing the mypy section of pyproject.toml; turns out its syntax was incorrect this whole time. Unsure if explicit tests are necessary in this instance, as they're already validated by the buildsystem itself.

Contributor Checklist:

  • I have created a new test or updated the unit tests to cover the new/changed functionality.
  • I have updated CHANGES.txt (and read the README.rst)
  • I have updated the appropriate documentation

@mwichmann
Copy link
Collaborator

In favor of this transition (and thanks for doing the gruntwork!). Looks fine for scons itself; the question is whether it will break other packaging efforts with no warning - distros, homebrew, etc.

@bdbaddog
Copy link
Contributor

Great work! Thanks!

@bdbaddog bdbaddog merged commit bc98dfc into SCons:master May 27, 2024
6 of 7 checks passed
@Repiteo Repiteo deleted the pyproject-migrate branch May 27, 2024 23:39
@mwichmann mwichmann added this to the 4.8 milestone May 28, 2024
@mwichmann mwichmann added the Release Any an all issues with releasing and packaging SCons itself label May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release Any an all issues with releasing and packaging SCons itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants